Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update Object Storage tests to mock account capabilities as needed #10602

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Jun 21, 2024

Description 📝

  • Updates Object Storage Cypress tests to mock account capabilities as needed 👤
    • We need to mock capabilities because the API recently turned on the Object Storage Access Key Regions capability and many of our tests were written under the assumption that Object Storage Access Key Regions was not returned in capabilities

How to test 🧪

  • Verify Cypress tests pass ✅

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added the e2e Indicates that a PR touches Cypress tests in some way label Jun 21, 2024
@bnussman-akamai bnussman-akamai self-assigned this Jun 21, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner June 21, 2024 15:22
@bnussman-akamai bnussman-akamai requested review from jdamore-linode and removed request for a team June 21, 2024 15:22
Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this fix out so quick 🛠️

Approved since these are now passing for me locally 🎉 but we should wait until CI passes -- also should we add a changeset?

@bnussman-akamai
Copy link
Member Author

I didn't add one because I think @cpathipa is going to merge this into the release branch. Not sure if adding one would throw things off

Copy link

github-actions bot commented Jun 21, 2024

Coverage Report:
Base Coverage: 83.12%
Current Coverage: 83.12%

@hkhalil-akamai
Copy link
Contributor

Let's make a ticket to add a version of this test with multi-cluster enabled (same for other tests).

@bnussman-akamai bnussman-akamai requested a review from a team as a code owner June 21, 2024 16:02
@bnussman-akamai bnussman-akamai requested review from dwiley-akamai and zaenab-akamai and removed request for a team June 21, 2024 16:02
@bnussman-akamai bnussman-akamai merged commit 33e2983 into linode:develop Jun 21, 2024
18 checks passed
cpathipa pushed a commit that referenced this pull request Jun 21, 2024
…eeded (#10602)

* mock account capabilities as needed

* Added changeset: Update Object Storage tests to mock account capabilities as needed for multi cluster

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Indicates that a PR touches Cypress tests in some way
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants